Skip to content

[v10] Remove Drone Windows concurrency limit#21199

Merged
tcsc merged 2 commits intobranch/v10from
tcsc/branch/v10/remove-concurrency-limit
Feb 4, 2023
Merged

[v10] Remove Drone Windows concurrency limit#21199
tcsc merged 2 commits intobranch/v10from
tcsc/branch/v10/remove-concurrency-limit

Conversation

@tcsc
Copy link
Copy Markdown
Contributor

@tcsc tcsc commented Feb 3, 2023

Windows builds are currently limited to 1 concurrent build for all stages
with the same name. This is causing unnecessary delay on the push build
queue, given that the Windows native builds are all set up to be independent
of one another.

Also updates the dronegen process to use a stock drone cli instance
proxied via tsh, to better match modern usage.

Windows builds are currently ylimted to 1 concurrent build for all
stages with the same name. This is causing unnecessary delay on the
push build queue, given that the Windowes native builds are all set
up to be independent of one another.
@tcsc tcsc requested review from codingllama and r0mant February 3, 2023 04:46
@github-actions github-actions Bot requested a review from kimlisa February 3, 2023 04:46
@tcsc tcsc changed the title [v10] Tcsc/branch/v10/remove concurrency limit [v10] Remove Drone Windows concurrency limit Feb 3, 2023
@codingllama
Copy link
Copy Markdown
Contributor

codingllama commented Feb 3, 2023

Is this a problem for other versions and/or master? I see similar lines here, for example:

teleport/.drone.yml

Lines 914 to 939 in 7d40f37

kind: pipeline
type: exec
name: build-native-windows-amd64
trigger:
event:
include:
- tag
ref:
include:
- refs/tags/v*
repo:
include:
- gravitational/*
workspace:
path: C:/Drone/Workspace/build-native-windows-amd64
platform:
os: windows
arch: amd64
node:
buildbox_version: teleport13
clone:
disable: true
depends_on:
- clean-up-previous-build
concurrency:
limit: 1

I did find #21201 for v11, but no similar PRs for v12 or master.

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from kimlisa February 3, 2023 16:32
@tcsc tcsc enabled auto-merge (squash) February 3, 2023 22:57
@tcsc tcsc merged commit 27e3175 into branch/v10 Feb 4, 2023
@tcsc tcsc deleted the tcsc/branch/v10/remove-concurrency-limit branch November 29, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants