RFD 103: Application Access Web UI Auth Flow#20138
Merged
Conversation
abc9698 to
8f7fbe3
Compare
zmb3
approved these changes
Jan 12, 2023
Collaborator
zmb3
left a comment
There was a problem hiding this comment.
Thanks for getting something written down.
hatched
approved these changes
Jan 12, 2023
GavinFrazar
approved these changes
Jan 12, 2023
Contributor
GavinFrazar
left a comment
There was a problem hiding this comment.
Thanks for making this! Only comment I have is this is for the Web UI w/ cookies only. For app access via mTLS we added an extra check that the client cert subject matches the user who created the session (but covering the mTLS scenario is I think out of scope of what this is documenting).
2245a7f to
52a262a
Compare
ac03c84 to
9c31522
Compare
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com>
9c31522 to
f090ad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the changes to the application access auth flow.
These changes have been implemented in #17592 and gravitational/webapps#1278