Add Connect docs about linking tsh#19903
Merged
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
ptgott,
r0mant,
sagesyr,
xinding33 and
zmb3
zmb3
reviewed
Jan 5, 2023
ptgott
approved these changes
Jan 5, 2023
Contributor
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
Approved with minor suggestions. Along with Zac, I also think we should use "Teleport Connect" instead of "Connect"
ravicious
force-pushed
the
ravicious/linking-tsh-docs
branch
from
58185a2 to
5b6ba92
Compare
Member
Author
|
The last commit adds a note which explains that ultimately Connect and tsh use different TELEPORT_HOME so changes made in one app will not be reflected in the other. I figured it might not be obvious, in the near future we might change this anyway, but at the moment it'd be best to capture this in the docs. |
zmb3
approved these changes
Jan 9, 2023
github-actions
Bot
removed request for
alexfornuto,
r0mant,
sagesyr and
xinding33
Contributor
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gravitational/webapps#1445 implemented RFD 99. tsh now is automatically added to PATH on Linux & Windows and macOS users can add it manually.
All we are missing is a section in the docs about it which is what this PR adds.