GCP CLI support: server-side request handler#19789
Merged
Conversation
2 tasks
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
2 times, most recently
from
987e04c to
d92542c
Compare
GavinFrazar
approved these changes
Jan 4, 2023
Tener
force-pushed
the
tener/gcloud-cli-auth
branch
from
b1543cb to
b09f034
Compare
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
from
d92542c to
71e3a69
Compare
smallinsky
reviewed
Jan 4, 2023
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
from
d5a27d2 to
f8a2788
Compare
Tener
force-pushed
the
tener/gcloud-cli-auth
branch
from
b09f034 to
ae22885
Compare
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
from
f8a2788 to
aa7754b
Compare
Tener
force-pushed
the
tener/gcloud-cli-auth
branch
from
ae22885 to
fdceb53
Compare
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
from
aa7754b to
adf88aa
Compare
Tener
force-pushed
the
tener/gcloud-cli-auth
branch
from
fdceb53 to
53e16a2
Compare
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
from
adf88aa to
54ccb28
Compare
greedy52
approved these changes
Jan 9, 2023
Contributor
greedy52
left a comment
greedy52
left a comment
There was a problem hiding this comment.
LGTM.
Only concern is on the pre-defined list of scopes. Not sure how often users need something else.
smallinsky
approved these changes
Jan 10, 2023
Contributor
Author
Thanks! Regarding pre-defined scopes: I took it from the default scope list used by |
- make debug log entry in appropriate place - document the default scope list - replace `context.WithTimeout` with `s.Clock.After` to avoid `time.Sleep` in tests. - cloud client is now being mocked, making `generateAccessToken` testeable. - update tests
- replace `context.WithTimeout` with `s.Clock.After` to avoid `time.Sleep` in tests.
Tener
force-pushed
the
tener/gcloud-cli-auth
branch
from
53e16a2 to
2e7c71e
Compare
Tener
force-pushed
the
tener/gcloud-cli-handler
branch
from
54ccb28 to
46d1ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server-side request handler forwarding the requests to GCP, required for #17257
To be applied on top of #19788.