Conversation
greedy52
approved these changes
Jan 3, 2023
capnspacehook
approved these changes
Jan 3, 2023
GavinFrazar
approved these changes
Jan 4, 2023
Contributor
GavinFrazar
left a comment
GavinFrazar
left a comment
There was a problem hiding this comment.
couple minor comments, but looks good
smallinsky
approved these changes
Jan 4, 2023
Tener
force-pushed
the
tener/gcloud-cli-api
branch
from
ff5eceb to
3c637b1
Compare
Tener
force-pushed
the
tener/gcloud-cli-rbac
branch
3 times, most recently
from
3b523ed to
04028b9
Compare
Tener
force-pushed
the
tener/gcloud-cli-api
branch
from
3c637b1 to
8ad4596
Compare
Tener
force-pushed
the
tener/gcloud-cli-rbac
branch
from
04028b9 to
c521c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RBAC changes to recognize
gcp_service_accounttrait as well as complementary allow/deny sections in roles. Required for #17257To be applied on top of #19785.