[v11] refactor app access middleware#19668
Merged
GavinFrazar merged 2 commits intobranch/v11from Dec 29, 2022
Merged
Conversation
github-actions
Bot
added
application-access
audit-log
github-actions
Bot
requested review from
Tener,
jakule,
smallinsky and
tigrato
smallinsky
approved these changes
Dec 28, 2022
tigrato
approved these changes
Dec 28, 2022
GavinFrazar
changed the base branch from
branch/v11
to
gavinfrazar/v11-add-app-access-dynamodb-event
Base automatically changed from
gavinfrazar/v11-add-app-access-dynamodb-event
to
branch/v11
December 29, 2022 18:22
* Move logic out of RoundTrip and into ServeHTTP as a middleware before handing off to oxy forwarder * Move AWS signing service code into lib/utils/aws/signing.go * use app server close context for audit event emitting * add go doc comments. * refactor request rewriting to make the copy in a more robust way. * pass status code as uint32 rather than casting in audit emitter * clone request instead of making a new request, and rewrite url to force https * update header handling * Set oxy forwarder to PassHostHeader=false to ensure the host header is the URL being sought. * Remove code that deleted forwarding headers previously, we should keep those (X-Forwarded-*). * Audit log the AWS Host sought rather than the incoming request Host header (prior behavior maintained, we just rewrite the request differently using Clone). * Remove obsolete header copying helper func
GavinFrazar
force-pushed
the
gavinfrazar/v11-refactor-app-access-middleware
branch
from
75e0957 to
576988a
Compare
GavinFrazar
deleted the
gavinfrazar/v11-refactor-app-access-middleware
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #19387
This will make backporting future changes in this area of the code easier, since the refactor changed things a lot.