AWS Athena ODBC driver support for App Access#19649
Merged
Conversation
5995ba7 to
bf973d1
Compare
GavinFrazar
approved these changes
Dec 23, 2022
Contributor
GavinFrazar
left a comment
There was a problem hiding this comment.
LGTM, glad the signing service refactor fixed a header signing issue I wasn't even aware of 😄
codingllama
approved these changes
Jan 3, 2023
smallinsky
approved these changes
Jan 10, 2023
…/8281_athena_odbc_driver_support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #8281
Note that both Athena JDBC driver and Timestream JDBC driver use Java SDK v1 so Teleport would not able to support them (details see #19366)
Changes
Interestingly, the copy header logic change from #19387 actually fixed an issue that AWS would reject ODBC driver requests when
Expect: 100-continueheaders are signed (by the old logic). I had a similar change prior to Gavin's refactor but it's no longer necessary.This PR then adds a new
athena-odbcformattsh proxy awsto dump pre-compiled list of ODBC properties.UX
Login
New proxy format