[v11] Improve error handling in Connect gateway integration test#19391
Merged
ravicious merged 1 commit intobranch/v11from Dec 15, 2022
Merged
[v11] Improve error handling in Connect gateway integration test#19391ravicious merged 1 commit intobranch/v11from
ravicious merged 1 commit intobranch/v11from
Conversation
mockTSHDEventsClient will most likely be called outside of the test goroutine, so we shouldn't use require.NoError there. helpers.SetupUserCreds returns an error which I did not inspect. The linter didn't warn me about it for some reason.
espadolini
approved these changes
Dec 15, 2022
zmb3
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #19145 to branch/v11