Bump gravitational/trace package version#19390
Merged
Conversation
ravicious
approved these changes
Dec 15, 2022
jakule
approved these changes
Dec 15, 2022
Collaborator
|
We need to update api/go.mod too, right? |
Contributor
Yes, I created a new release of trace v1.1.20 and updated api. |
jakule
force-pushed
the
tener/fix-race-trace-wrap
branch
from
5b65dea to
73d5559
Compare
jakule
force-pushed
the
tener/fix-race-trace-wrap
branch
from
611d1b4 to
4b028a7
Compare
Contributor
Contributor
Author
|
@jakule the fix would be handy for v9 and v10 too, as it is causing issues: Let me know whether you'd like to backport it yourself or leave it to me. |
Tener
added a commit
that referenced
this pull request
Dec 29, 2022
Tener
added a commit
that referenced
this pull request
Dec 29, 2022
Tener
added a commit
that referenced
this pull request
Dec 29, 2022
Tener
added a commit
that referenced
this pull request
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of
gravitational/traceis safe from possible race conditions arising when error is modified (e.g. viatrace.Wrap()/trace.AddUserMessage()) and displayed at the same time (trace.Error()).TODO:
go.modafter Remove mutating state methods - breaking change trace#85 is mergedFixes #19294