Fix an issue tsh throws assertion error on REDIS_REPLY_STATUS for Redis 7#19364
Merged
Fix an issue tsh throws assertion error on REDIS_REPLY_STATUS for Redis 7#19364
Conversation
greedy52
commented
Dec 14, 2022
|
|
||
| "github.com/gravitational/trace" | ||
| "github.com/jonboulle/clockwork" | ||
| "github.com/siddontang/go/log" |
Contributor
Author
There was a problem hiding this comment.
caught this when go mod tidy tries to add this a "direct" dependency
jakule
approved these changes
Dec 14, 2022
smallinsky
approved these changes
Dec 14, 2022
Contributor
greedy52
added a commit
that referenced
this pull request
Dec 15, 2022
greedy52
added a commit
that referenced
this pull request
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19240
Error from
tsh db connect <redis-7>Root cause:
redis-clisendsCOMMAND DOCSto construct docs for commands and expect status type (+<status>) as part of the response. The go-redis driver however reads status into golang strings and writes them as string types ($<len><string>).Changes:
Notes:
COMMAND DOCSis new to Redis 7, so usingredis-cli6.2 would not see this issueCOMMAND XXXpermissions soredis-cliwill always getNO PERMthus not seeing this error.