helm: add PodMonitor support#19291
Merged
hugoShaka merged 1 commit intohugo/chart-split-proxy-authfrom Dec 19, 2022
Merged
Conversation
7 tasks
webvictim
reviewed
Dec 14, 2022
hugoShaka
force-pushed
the
hugo/chart-split-proxy-auth
branch
from
f844519 to
620b06f
Compare
marcoandredinis
approved these changes
Dec 16, 2022
strideynet
approved these changes
Dec 16, 2022
hugoShaka
force-pushed
the
hugo/chart-service-monitor
branch
from
5c47298 to
83fe1f5
Compare
github-actions
Bot
removed request for
EdwardDowling,
programmerq and
tigrato
hugoShaka
added a commit
that referenced
this pull request
Jan 5, 2023
This was referenced Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #18274
Fixes #13260
Adds prometheus-operator support for the chart. With this change, users can leverage their existing Prometheus deployments to collect Teleport metrics without manually configuring it.
I suggest using a
PodMonitorinstead of aServiceMonitorbecause the chart v12 will deploy multiple pods, multiple services sometimes overlapping. A PodMonitor seemed easier and more adequate.Note: merge only once the auth/proxy split PR has been merged