Register database engines directly from db lib#19279
Merged
Conversation
timothyb89
approved these changes
Dec 14, 2022
Contributor
timothyb89
left a comment
There was a problem hiding this comment.
Definitely nice to see init functions go away
smallinsky
approved these changes
Dec 16, 2022
…/register_db_engine_directly_from_db_lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of
As suggested by #19239 (comment),
srv/libnow explicitly register the database engines, instead of relying on importing the "engine" packages.Also added a check to confirm engines are registered when creating a database service. This helps capture the problem in test and integration test