[v11] Fix issue "redis" engine is not registered (#19239)#19251
Merged
greedy52 merged 5 commits intobranch/v11from Dec 12, 2022
Merged
[v11] Fix issue "redis" engine is not registered (#19239)#19251greedy52 merged 5 commits intobranch/v11from
greedy52 merged 5 commits intobranch/v11from
Conversation
greedy52
added
database-access
smallinsky
approved these changes
Dec 9, 2022
r0mant
approved these changes
Dec 9, 2022
r0mant
reviewed
Dec 9, 2022
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@greedy52 @smallinsky Why didn't the tests catch this issue? Should we update our tests?
Contributor
Author
@r0mant test explicitly imports redis for other things so it didn't catch this. Will do a separate change to improve this so it won't happen again. Probably something like this #19239 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #19239