Fix Kubernetes version detection on EKS#19188
Merged
Conversation
strideynet
approved these changes
Dec 8, 2022
Co-authored-by: Noah Stride <noah.stride@goteleport.com>
7 tasks
nklaassen
approved these changes
Dec 8, 2022
| userInfo, err := a.kubernetesTokenValidator.Validate(ctx, req.IDToken) | ||
| if err != nil { | ||
| return trace.Wrap(err) | ||
| return trace.WrapWithMessage(err, "failed to validate the Kubernetes token") |
Contributor
There was a problem hiding this comment.
funny, I've never seen trace.WrapWithMessage before, probably since regular trace.Wrap lets you include a message already. I guess it avoids 2 checks when you already know err != nil && len(args) > 0. TIL
Co-authored-by: Nic Klaassen <nic@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in the kubernetes join method.
EKS is not formatting version.Minor as an integer, (e.g. I got
23+). It is not possible to reliably parse this field and this blocks nodes from joining.