[v10] Optimize trait loop evaluation#19183
Merged
vitorenesduarte merged 3 commits intobranch/v10from Dec 8, 2022
Merged
Conversation
Refactored all tests under "lib/services/suite" to use testify instead of gocheck.
This commit reduces the number of `log.Debug`s in the trait loop evaluation in case of a mismatch. This commit also optimizes the trait eval loop ensuring that each regexp is compiled at-most once, and only if strictly needed.
codingllama
approved these changes
Dec 8, 2022
zmb3
approved these changes
Dec 8, 2022
fheinecke
pushed a commit
that referenced
this pull request
Dec 16, 2022
* Refactor tests under services package. Refactored all tests under "lib/services/suite" to use testify instead of gocheck. * Optimize trait loop evaluation (#19097) This commit reduces the number of `log.Debug`s in the trait loop evaluation in case of a mismatch. This commit also optimizes the trait eval loop ensuring that each regexp is compiled at-most once, and only if strictly needed. Co-authored-by: Russell Jones <rjones@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #19097 to branch/v10.
This PR first cherry picks #14221 (resolving some conflicts), which allows the cherry-pick of #19097 to work without conflicts.