daemon.Service: Rename GetCluster to ResolveFullCluster#19180
Merged
daemon.Service: Rename GetCluster to ResolveFullCluster#19180
Conversation
avatus
approved these changes
Dec 8, 2022
zmb3
approved these changes
Dec 8, 2022
Contributor
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon.Service.GetCluster was added in #17497. On the initial load of Connect, we needed to check if the cluster supports access requests so that we can show the UI responsible for managing them. To do that, we had to make a request to the cluster as that information couldn't have been read from the user cert. So the old
ResolveClustermethod which just read data from the disk wasn't enough.In
b398e0306in #17950 I expanded the comment forResolveClusterandGetClusterto highlight the difference between them. During code review, @AntonAM suggested renamingResolveClustertoResolveClusterFromStorage. I thought it was a good idea butResolveClusterwas used in quite a few places so I didn't want to add more noise to that PR.Now I came back to rename the method. But I realized that instead of renaming
ResolveCluster, which is the default that's used in multiple places in lib/teleterm, I should renameGetClusterinstead to highlight that it does something different.