Merged
Conversation
hugoShaka
force-pushed
the
hugo/change-helm-unittest-plugin
branch
from
cfaa4ac to
f1dc60f
Compare
hugoShaka
force-pushed
the
hugo/change-helm-unittest-plugin
branch
from
f1dc60f to
6d7514b
Compare
hugoShaka
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
r0mant
approved these changes
Dec 5, 2022
| image: ghcr.io/gravitational/teleport-buildbox:teleport12 | ||
| env: | ||
| HELM_PLUGINS: /root/.local/share/helm/plugins | ||
| # TODO(hugoShaka) remove the '-new' prefix when updating to teleport13 buildbox |
Collaborator
There was a problem hiding this comment.
In teleport13 we can probably just get rid of this environment variable, no?
Contributor
Author
There was a problem hiding this comment.
If we set it in the image, yes.
Contributor
Author
There was a problem hiding this comment.
It's not clear for me which user the CI is running as. If it's root root ci we should be able to remove it entirely. However the fact the variable was set previously hints this might not be the case.
tigrato
approved these changes
Dec 5, 2022
github-actions
Bot
removed request for
gabrielcorado,
rosstimothy and
webvictim
zmb3
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the tests syntax to be compatible with https://github.com/quintush/helm-unittest/.
It depends on the new unittest plugin added by #18945
It does the following changes: