Skip to content

buildbox: add new helm unittest plugin fork #18945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoShaka merged 3 commits into from
Dec 2, 2022
Merged

buildbox: add new helm unittest plugin fork #18945

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9281516
Add new helm unittest plugin fork into the buildbox
hugoShaka Dec 1, 2022
d430d20
Merge branch 'master' into hugo/buildbox-12.1
hugoShaka Dec 2, 2022
e3fc022
Merge branch 'master' into hugo/buildbox-12.1
hugoShaka Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions build.assets/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,14 @@ RUN go install github.com/daixiang0/gci@v0.8.2
RUN (mkdir -p helm-tarball && curl -L https://get.helm.sh/helm-v3.5.2-$(go env GOOS)-$(go env GOARCH).tar.gz | tar -C helm-tarball -xz && \
cp helm-tarball/$(go env GOOS)-$(go env GOARCH)/helm /bin/ && \
rm -r helm-tarball*)

# TODO(hugoShaka): remove this backward compatible hack with teleportv13 buildbox
RUN helm plugin install https://github.com/quintush/helm-unittest && \
Comment thread
r0mant marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Collaborator

@r0mant r0mant Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we set HELM_PLUGINS for the helm plugin install command, otherwise it would install it in the same location as the old plugin below, no?

Copy link
Copy Markdown
Contributor Author

@hugoShaka hugoShaka Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do this, but helm did not respect the variable during installation 🙄 this is why the plugin is copied somewhere else, then deleted with helm plugin uninstall unittest. In the end we have 3 plugin installed:

  • new version in /home/ci/.local/share/helm/plugins-new
  • old version in /home/ci/.local/share/helm/plugins
  • old version in /root/.local/share/helm/plugins-new

mkdir -p /home/ci/.local/share/helm && \
cp -r /root/.local/share/helm/plugins /home/ci/.local/share/helm/plugins-new && \
chown -R ci /home/ci/.local/share/helm && \
helm plugin uninstall unittest && \
HELM_PLUGINS=/home/ci/.local/share/helm/plugins-new helm plugin list
RUN helm plugin install https://github.com/vbehar/helm3-unittest && \
mkdir -p /home/ci/.local/share/helm && \
cp -r /root/.local/share/helm/plugins /home/ci/.local/share/helm && \
Expand Down