Add extra database validations to CreateDatabase#18776
Merged
Conversation
greedy52
added
database-access
greedy52
changed the title
greedy52
commented
Nov 24, 2022
| // CreateDatabase creates a new database resource. | ||
| func (s *DatabaseService) CreateDatabase(ctx context.Context, database types.Database) error { | ||
| if err := database.CheckAndSetDefaults(); err != nil { | ||
| if err := services.ValidateDatabase(database); err != nil { |
Contributor
Author
There was a problem hiding this comment.
this is the only real change, rest are moving things around.
marcoandredinis
approved these changes
Nov 25, 2022
smallinsky
approved these changes
Nov 25, 2022
Contributor
Author
|
Thanks for the quick review 😄 |
Contributor
greedy52
added a commit
that referenced
this pull request
Nov 25, 2022
greedy52
added a commit
that referenced
this pull request
Nov 28, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #17454
Why
When creating databases through static config, we have a bunch of awesome pre-checks to validate the inputs. It would be nice to have the same checks when creating database through the webapi (or
tctl)Changes
redis.ParseRedisAddressfromlib/srv/db/redis/connection.goits own packagelib/srv/db/redis/connectionservice.Database.CheckAndSetDefaultstoservices.ValidateDatabase(and one check toapi.DatabaseV3.CheckAndSetDefaults)services/local/databases.gosimilar to other validations inservices/local