[v10] Reformat imports GCI #18746
Merged
jakule merged 6 commits intobranch/v10from Dec 16, 2022
Merged
Conversation
github-actions
Bot
added
application-access
audit-log
mdwn
approved these changes
Nov 23, 2022
codingllama
reviewed
Nov 24, 2022
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
LGTM, thanks for backporting.
Let's get the e/ ref updated and a green CI run, otherwise happy to approve.
jakule
force-pushed
the
jakule/v10/reformat-gci
branch
from
220738d to
6d4578e
Compare
jakule
force-pushed
the
jakule/v10/reformat-gci
branch
from
6d4578e to
8e74d1a
Compare
codingllama
approved these changes
Dec 16, 2022
Contributor
|
Thanks for the backport! |
fheinecke
pushed a commit
that referenced
this pull request
Dec 16, 2022
* Add GCI linter and format target * Revert golangci-lint to 1.46.0 * Disable GCI in golangci-lint * Downgrade GCI to 0.7.0 * GCI all files * Suppress GCI/goimports linter errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #17894
I backported the GCI changes and reformat all files to avoid resolving all conflicts.
TODO: