Make 'tsh scp' error messages more useful#18657
Merged
capnspacehook merged 1 commit intomasterfrom Apr 12, 2023
Merged
Conversation
github-actions
Bot
added
the
tsh
capnspacehook
added
backport/branch/v10
sftp
lxea
approved these changes
Nov 22, 2022
r0mant
approved these changes
Apr 7, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@capnspacehook Is this change still applicable now that we're moving back to the upstream library?
I think it's a good UX improvement overall so if it's still valid let's bring this up-to-date and merge, otherwise just close the PR.
Contributor
Author
|
I think I can get this working after I merge in a few other SFTP PRs without upstream changes needed, I'll update this PR once #24260 is merged. |
capnspacehook
force-pushed
the
capnspacehook/tsh-scp-err-msgs
branch
from
9385b99 to
7ed9b70
Compare
codingllama
approved these changes
Apr 12, 2023
avatus
approved these changes
Apr 12, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
After other feedback addressed
capnspacehook
force-pushed
the
capnspacehook/tsh-scp-err-msgs
branch
from
7ed9b70 to
dee8213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
ssh_file_copyrole option being set tofalseprevented a user from copying files, this is the current output:After this change, the output is:
Fixes #15621.