Conversation
corkrean
requested review from
hugoShaka
and removed request for
klizhentas and
russjones
Contributor
|
The PR is missing documentation (the new field should be added to the helm reference page), the JSONSchema entry for the value (in values.schema.json) and a lint/test case with either a snapshot or a field check. https://github.com/gravitational/teleport/pull/17636/files can be used as a reference Helm PR (no need to edit the README though). |
Contributor
Author
|
#18857 will allow users to create custom config options not already exposed by the helm chart, so I'm closing this PR in favor of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.