Forward traces from the web UI#18519
Merged
rosstimothy merged 6 commits intomasterfrom Nov 18, 2022
Merged
Conversation
rosstimothy
force-pushed
the
tross/proxy_ui_trace_forwarding
branch
from
465b838 to
5cc2c3d
Compare
codingllama
reviewed
Nov 16, 2022
codingllama
reviewed
Nov 16, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| require.Empty(t, req.Header.Get(tracing.TraceParent)) | |
| require.Empty(t, req.Header.Get(tracing.TraceParent), "TraceParent header mismatch") |
Same for others.
Contributor
There was a problem hiding this comment.
Suggested change
| require.Empty(t, spans) | |
| require.Empty(t, spans, "Spans mismatch") |
Same for others. (Message could be better, up to you.)
codingllama
approved these changes
Nov 17, 2022
zmb3
reviewed
Nov 17, 2022
zmb3
approved these changes
Nov 17, 2022
Adds a `/webapi/traces` endpoint to the proxy web handler to allow receiving traces from the UI so that they can be forwarded to the configured exporter in the proxy_service. To accomodate traces coming in via websockets the tracing handler is updated to pull tracing context first from the standard headers and fallback to retrieving it from a query parameter as web sockets from the UI cannot alter headers. Additionally update `web.Terminal` to propagate the tracing context properly and instruments some of the functions to ensure spans from the UI are properly correlated to spans on the backend.
rosstimothy
force-pushed
the
tross/proxy_ui_trace_forwarding
branch
from
577f84d to
e4a9031
Compare
Contributor
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Nov 18, 2022
Adds a `/webapi/traces` endpoint to the proxy web handler to allow receiving traces from the UI so that they can be forwarded to the configured exporter in the proxy_service. To accomodate traces coming in via websockets the tracing handler is updated to pull tracing context first from the standard headers and fallback to retrieving it from a query parameter as web sockets from the UI cannot alter headers. Additionally update `web.Terminal` to propagate the tracing context properly and instruments some of the functions to ensure spans from the UI are properly correlated to spans on the backend.
rosstimothy
added a commit
that referenced
this pull request
Nov 18, 2022
Adds a `/webapi/traces` endpoint to the proxy web handler to allow receiving traces from the UI so that they can be forwarded to the configured exporter in the proxy_service. To accomodate traces coming in via websockets the tracing handler is updated to pull tracing context first from the standard headers and fallback to retrieving it from a query parameter as web sockets from the UI cannot alter headers. Additionally update `web.Terminal` to propagate the tracing context properly and instruments some of the functions to ensure spans from the UI are properly correlated to spans on the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
/webapi/tracesendpoint to the proxy web handler to allow receiving traces from the UI so that they can be forwarded to the configured exporter in the proxy_service.To accomodate traces coming in via websockets the tracing handler is updated to pull tracing context first from the standard headers and fallback to retrieving it from a query parameter as web sockets from the UI cannot alter headers.
Additionally update
web.Terminalto propagate the tracing context properly and instruments some of the functions to ensure spans from the UI are properly correlated to spans on the backend.