[v9] Allow non-moderated sessions during outage#18442
Merged
rosstimothy merged 2 commits intobranch/v9from Nov 21, 2022
Merged
Conversation
In the event that a SessionTracker wasn't able to be persisted in the backend the session was aborted and the user received an error about being unable to upsert session trackers. While this is required in the event that the session being established is a moderated session, other sessions should be allowed to be created without a SessionTracker resource existing in the backend. To allow non-moderated sessions to be established in the event there was a failure persisting the resource we can proceed in the same manner as when the recording mode does not match the component. This ensures that a local SessionTracker resource is created, but any operations performed on it are not attempted to be sent to the Auth server. The session `log` was also updated to include a `session_id` field so that it doesn't need to be added to every individual log message. Closes #17024 and #17026
rosstimothy
force-pushed
the
tross/backport-17309/v9
branch
from
59a25ee to
d3ee25a
Compare
Contributor
Author
|
friendly ping @r0mant @capnspacehook |
r0mant
approved these changes
Nov 21, 2022
capnspacehook
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #17309 to branch/v9
Note: this also contains the changes to
lib/srv/sessiontracker.gofrom #15155