[v10] Deflake TestResizeTerminal#18407
Merged
zmb3 merged 3 commits intobranch/v10from Nov 17, 2022
Merged
Conversation
This test made separate reads, each waiting for some conditions to be met. Due to timing, it was possible that the events expected in the second read got included in the first batch of reads and discarded. Fix this by reading in a single batch and waiting for all required conditions to be met. Closes #13607
nklaassen
approved these changes
Nov 16, 2022
kimlisa
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test made separate reads, each waiting for some conditions to be met. Due to timing, it was possible that the events expected in the second read got included in the first batch of reads and discarded.
Fix this by reading in a single batch and waiting for all required conditions to be met.
Closes #13607
Backports #18391