[v10] Fixes node selector, removes concurrency limit on windows builds#18337
Merged
tcsc merged 4 commits intobranch/v10from Nov 10, 2022
Merged
[v10] Fixes node selector, removes concurrency limit on windows builds#18337tcsc merged 4 commits intobranch/v10from
tcsc merged 4 commits intobranch/v10from
Conversation
espadolini
approved these changes
Nov 10, 2022
rosstimothy
approved these changes
Nov 10, 2022
| p.DependsOn = []string{tagCleanupPipelineName} | ||
| p.Trigger = triggerTag | ||
|
|
||
| p.Concurrency.Limit = 1 |
Contributor
Author
There was a problem hiding this comment.
The concurrent limits have been left for tag builds, as there are flow-on concurrency concern due to artifact uploading, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Drone node selector was improperly specified as
nodesinstead ofnode, causing Drone to stall builds.Also removes the concurrency limit on Windows push builds. As there are separate builders for v10, v11 and v12. Given that the concurrency limits are enforced across all builds with the same name, they serialise builds from different teleport versions. it seems wasteful to have a builder for v10 sit idle while waiting a v11 build completes.
The concurrent limits have been left for tag builds, as there are flow-on concurrency concern due to artifact uploading, etc.