Close local proxy conn if middleware errors#18242
Merged
GavinFrazar merged 14 commits intoNov 16, 2022
Merged
Conversation
capnspacehook
approved these changes
Nov 7, 2022
ravicious
approved these changes
Nov 8, 2022
ravicious
reviewed
Nov 8, 2022
rosstimothy
reviewed
Nov 8, 2022
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
rosstimothy
reviewed
Nov 9, 2022
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Contributor
Author
|
@rosstimothy need your approval for group 1 reviewers |
rosstimothy
approved these changes
Nov 15, 2022
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Apologies this PR wasn't showing up in my waiting to be reviewed queue
smallinsky
approved these changes
Nov 16, 2022
GavinFrazar
added a commit
that referenced
this pull request
Nov 16, 2022
* Close connection on middleware error after accepting connection in local proxy * add comment
GavinFrazar
added a commit
that referenced
this pull request
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix, this PR just closes the local proxy connection if the middleware errors for whatever reason. This prevents a client from waiting on a connection. See this discussion: #16958 (comment)
Added a test with a read deadline to verify that clients do not hang when the middleware has some error.