Added multiarch Teleport Lab support#18015
Closed
fheinecke wants to merge 33 commits into
Closed
Conversation
This reverts commit cbe2692.
Contributor
Author
|
This PR is suspended pending a resolution to the drone.yml file size limitation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third and final part of a series of feature PRs updating drone/dronegen to support multiarch builds.
The primary purpose of this PR is to add multiarch Teleport Lab container images. This includes amd64, arm, and arm64 images under the
$MAJOR_VERSIONtag on each release.This includes three sets of minor changes outside of Teleport Lab specific dronegen changes:
downloadTeleportDockerfileStepwas renamed todownloadDockerfileStepand the produced step name was simplified due to Drone step name length limitationsArchSetupStepscontain no commands, then the empty step is not added to the pipeline but treated as a dependency stepPer usual there is a large number of
.drone.ymlchanges. Here's a breakdown of what changed:downloadTeleportDockerfileSteprefactoringgit diffmatching up the two file versions in different places. See here for an example.Related PRs:
Test runs prior to merging PR: