Conversation
github-actions
Bot
added
audit-log
codingllama
reviewed
Oct 31, 2022
strideynet
approved these changes
Oct 31, 2022
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
I'm happy w/ this beyond points already raised by @codingllama
jakule
force-pushed
the
jakule/gci-docker
branch
from
6ba28aa to
1077c27
Compare
codingllama
approved these changes
Nov 3, 2022
| echo "gci is not installed or it's missing from PATH, consider installing it 'go install github.com/daixiang0/gci@latest' or use 'make -C build.assets/ fix-imports'";\ | ||
| exit 1;\ | ||
| fi | ||
| gci write -s 'standard,default,prefix(github.com/gravitational/teleport)' --skip-generated . |
Contributor
There was a problem hiding this comment.
Nice, I didn't realize gci write . worked.
Contributor
Author
There was a problem hiding this comment.
**/*.go doesn't work in Makefile as this pattern goes only one level deep (the same as */*.go) It's super confusing as gci runs without an error but doesn't do much.
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #17894 has been merged, we discovered a few issues with using
golanglint-cias a tool to run GCI:golanglint-ci, the output may differgolanglint-cirequire all build tags to be provided, and some combinations (bpfon Mac) are not supportedgolanglint-cionly includes the files that matchGOOSexamples/directory is always skippedSwitching to
gcishould solve all the above problems. The only con of this solution is the necessity of installinggcion your system. To avoid that, I've added it to the buildbox, so it can be triggered from there.