Fix ListResources for WindowsDesktops#17093
Merged
Merged
Conversation
ListResources was adding the namespace to the backend key when retrieving WindowsDesktopServices, however UpsertWindowsDesktopService doesn't include the namespace in the prefix. This results in never getting any items from the backend. Removing the namespace in the prefix to match GetWindowsDesktopService revealed that we were also trying to unmarshal the resource as a types.Server. Switching the unmarshal function to use `services.UnmarshalWindowsDesktopService` as GetWindowsDesktopService allows ListResources to provide the correct resources. A new test case for WindowsDesktops was added to `local.TestListResources` to prevent any regressions.
smallinsky
approved these changes
Oct 6, 2022
Contributor
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Oct 6, 2022
ListResources was adding the namespace to the backend key when retrieving WindowsDesktopServices, however UpsertWindowsDesktopService doesn't include the namespace in the prefix. This results in never getting any items from the backend. Removing the namespace in the prefix to match GetWindowsDesktopService revealed that we were also trying to unmarshal the resource as a types.Server. Switching the unmarshal function to use `services.UnmarshalWindowsDesktopService` as GetWindowsDesktopService allows ListResources to provide the correct resources. A new test case for WindowsDesktops was added to `local.TestListResources` to prevent any regressions.
rosstimothy
added a commit
that referenced
this pull request
Oct 6, 2022
ListResources was adding the namespace to the backend key when retrieving WindowsDesktopServices, however UpsertWindowsDesktopService doesn't include the namespace in the prefix. This results in never getting any items from the backend. Removing the namespace in the prefix to match GetWindowsDesktopService revealed that we were also trying to unmarshal the resource as a types.Server. Switching the unmarshal function to use `services.UnmarshalWindowsDesktopService` as GetWindowsDesktopService allows ListResources to provide the correct resources. A new test case for WindowsDesktops was added to `local.TestListResources` to prevent any regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListResourceswas adding the namespace to the backend key when retrieving WindowsDesktopServices, howeverUpsertWindowsDesktopServicedoesn't include the namespace in the prefix. This results in never getting any items from the backend.Removing the namespace in the prefix to match
GetWindowsDesktopServicerevealed that we were also trying to unmarshal the resource as atypes.Server. Switching the unmarshal function to useservices.UnmarshalWindowsDesktopServiceto matchGetWindowsDesktopServiceallowsListResourcesto provide the correct resources.A new test case for WindowsDesktops was added to
local.TestListResourcesto prevent any regressions.