Connect: Fix premature proxyClient.Close() when getting kube clusters#16538
Merged
Connect: Fix premature proxyClient.Close() when getting kube clusters#16538
Conversation
ravicious
approved these changes
Sep 20, 2022
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
As I already told Grzegorz, I grepped lib/teleterm for var authClient auth.ClientI and cluster_kubes.go was the only outstanding place which had this problem.
zmb3
approved these changes
Sep 20, 2022
Contributor
gzdunek
added a commit
that referenced
this pull request
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes fetching kubes fails (in my case it happens only for local cluster).
This is the same problem as here: #14230.