[v10] Apply linters to legacy protos#15961
Merged
Merged
Conversation
codingllama
changed the title
codingllama
changed the title
codingllama
requested review from
ravicious and
rosstimothy
and removed request for
greedy52 and
jakule
codingllama
force-pushed
the
codingllama/v10-lint-legacy-protos
branch
from
2f30b07 to
dcbea4e
Compare
strideynet
approved these changes
Aug 31, 2022
ravicious
approved these changes
Aug 31, 2022
codingllama
force-pushed
the
codingllama/v10-lint-legacy-protos
branch
from
dcbea4e to
f5e38ea
Compare
Contributor
Author
|
/gcbrun |
Applies linters to legacy protos and adds a few additional Makefile targets to make it easier to manage protos locally. Proto linters now run in CI. #15187 * Apply linters to legacy protos * Handle new folders in genproto.sh, reset gen/proto if exists * Lint and format lib/teleterm as part of protos/all
codingllama
force-pushed
the
codingllama/v10-lint-legacy-protos
branch
from
f5e38ea to
09bd6a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies linters to legacy protos and adds a few additional Makefile targets to
make it easier to manage protos locally.
Proto linters now run in CI.
#15187
Backport #15879 to branch/v10