Remove Stripe from Content-Security-Policy header#15891
Merged
Conversation
Teleport Cloud no longer handles payments via Stripe, so no need to whitelist Stripe in CSP for `script-src` and `frame-src`.
Contributor
|
I'm not sure I have enough context on this change -- can we pull in the engineer who removed stripe billing? @pierrebeaucamp: do you know who was involved in removing/deprecating stripe billing for cloud? Or does this look reasonable to you? |
Contributor
Author
@pierrebeaucamp has provided his blessing -- https://gravitational.slack.com/archives/C010BD557L6/p1661255057189919?thread_ts=1661204049.391859&cid=C010BD557L6 |
Collaborator
|
For reference, the stripe SDK was removed from Teleport in https://github.com/gravitational/webapps.e/pull/69 |
wadells
approved these changes
Sep 9, 2022
zmb3
approved these changes
Sep 13, 2022
Contributor
|
@reedloden See the table below for backport results.
|
This was referenced Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teleport Cloud no longer handles payments via Stripe, so no need to whitelist Stripe in CSP for
script-srcandframe-src.