Add lock target to lock.create event#15865
Merged
Merged
Conversation
zmb3
force-pushed
the
zmb3/add-lock-target-to-audit-event
branch
3 times, most recently
from
f4d06a6 to
031caee
Compare
strideynet
approved these changes
Aug 30, 2022
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Changes look good.
There's a test named TestUpsertDeleteLockEventsEmitted which could be updated to ensure that this field is set properly.
This adds the target (which may be a user, role, node, login, etc) to the lock.create audit event. In order to do this, I had to break the dependency from events->types, but that was a minimal change. Fixes #15644
zmb3
force-pushed
the
zmb3/add-lock-target-to-audit-event
branch
from
031caee to
150d838
Compare
hatched
approved these changes
Aug 30, 2022
Contributor
zmb3
added a commit
that referenced
this pull request
Aug 30, 2022
This adds the target (which may be a user, role, node, login, etc) to the lock.create audit event. In order to do this, I had to break the dependency from events->types, but that was a minimal change. Fixes #15644
zmb3
added a commit
that referenced
this pull request
Aug 31, 2022
zmb3
added a commit
that referenced
this pull request
Aug 31, 2022
zmb3
added a commit
that referenced
this pull request
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the target (which may be a user, role, node, login, etc)
to the lock.create audit event.
In order to do this, I had to break the dependency from events->types,
but that was a minimal change.
Fixes #15644