Fix azure protobuf#15864
Conversation
zmb3
left a comment
There was a problem hiding this comment.
Change looks good, but feels like there should be a linter that can catch this and prevent it from happening again. Mind investigating?
|
Wouldn't #15856 catch things like this? cc @codingllama Although it looks like "legacy" protobufs are ignored there. |
|
I would think it best to have a Go linter that catches this in the generated code, as opposed to trying to teach buf about |
|
In fact, looks like |
I don't think linters would go as deep as gogo JSON tags, sadly. Btw, since we are talking about this, I do have a follow up to enable some linting in legacy protos. Just wait for it. :) |
0a20384 to
917da10
Compare
|
@GavinFrazar See the table below for backport results.
|
I made a mistake in #15673 yesterday adding a field to Azure metadata protobuf, giving "ResourceID" the same json key as "Name".