Connect: Add tests for ParseClusterURI#15863
Merged
Merged
Conversation
Use testify/require, enable parallel tests
strideynet
reviewed
Aug 30, 2022
strideynet
approved these changes
Aug 30, 2022
| { | ||
| "/clusters/cluster.sh", | ||
| uri.NewClusterURI("cluster.sh"), | ||
| }, { |
Contributor
There was a problem hiding this comment.
I think gofmt might need running on this file :)
Member
Author
There was a problem hiding this comment.
Hmm I'm running gofmt on save and running it manually gofmt -d api/utils/uri_test.go doesn't return anything. 🤔
Before the last commit line 64 was }{{ instead of just }{ and I changed it there.
Member
Author
There was a problem hiding this comment.
It might be weird handling of tabs by GitHub?
Contributor
There was a problem hiding this comment.
Oh ok, maybe I'm confusing gofmt with something I've got installed, but I'd have expected line 68 to match lines 71 and 75.
Member
Author
There was a problem hiding this comment.
Ah, I see, that was probably a leftover of that change from }{{ to }{.
Contributor
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on a new feature and at some point I needed to extract a cluster URI from a resource URI. I wasn't sure if
uri.ParseClusterURIbehaves the way I expect it to so I decided to add some tests.As this change is unrelated to the actual feature I'm working on, I decided to make a separate PR to keep the other PR smaller.
If you're not familiar with Connect's URIs, the readme has a quick overview of them.