Remove deprecated upsert password endpoint#15855
Merged
Merged
Conversation
greedy52
approved these changes
Aug 25, 2022
rosstimothy
reviewed
Aug 25, 2022
| require.Error(t, err) | ||
|
|
||
| err = clt.UpsertPassword("user1", pass) | ||
| err = tt.server.Auth().UpsertPassword("user1", pass) |
Contributor
There was a problem hiding this comment.
How come clt.UpsertPassword was replaced with tt.server.Auth().UpsertPassword instead of clt.ChangePassword?
Contributor
Author
There was a problem hiding this comment.
So this test is relying on some ✨ additional and unexpected behaviour ✨ of the UpsertPassword method on the auth server which means if you upsert the password for a user that does not exist, the user is created.
zmb3
approved these changes
Aug 26, 2022
Contributor
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Aug 30, 2022
* remove UpsertPassword endpoint from Auth HTTP API server * fix merge * Fix TestUsersCRUD
strideynet
added a commit
that referenced
this pull request
Aug 30, 2022
* remove UpsertPassword endpoint from Auth HTTP API server * fix merge * Fix TestUsersCRUD
strideynet
added a commit
that referenced
this pull request
Aug 31, 2022
strideynet
added a commit
that referenced
this pull request
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This endpoint is replaced by the ChangePassword endpoint.