Skip to content

ami: update Grafana to 9.0.7 (#4218)#15585

Merged
hugoShaka merged 3 commits into
masterfrom
4218-update-grafana-in-ami
Aug 17, 2022
Merged

ami: update Grafana to 9.0.7 (#4218)#15585
hugoShaka merged 3 commits into
masterfrom
4218-update-grafana-in-ami

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Aug 16, 2022

Fixes #4218

The PR:

This commit:
- Bumps the grafana version
- Fixes the packer script failing when `DEBUG` is unset
- Makes nginx propagate the Host header required since
  https://grafana.com/blog/2022/02/08/grafana-7.5.15-and-8.3.5-released-with-moderate-severity-security-fixes/
- Makes nginx proxy websocket calls properly (since grafana 8)
- Retab nginx conf files that were a mix of tabs and spaces
- Makes Terraform compute s3 files md5 to detect and apply changes
@hugoShaka
Copy link
Copy Markdown
Contributor Author

hugoShaka commented Aug 16, 2022

Note: I'm not sure if this should be backported to v9/v10.

Pros:

  • this includes a bunch of Grafana security fixes
  • The terraform md5 computation is a painful gotcha
  • Our monitor instances are mainly stateless and this has no interaction with the product

Cons:

  • this would break the semver, biggets change is the grafana renderer removal

Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to just keep this update for master branch.

Comment thread examples/aws/terraform/ha-autoscale-cluster/s3.tf Outdated
Comment thread examples/aws/terraform/ha-autoscale-cluster/s3.tf Outdated
Comment thread examples/aws/terraform/ha-autoscale-cluster/s3.tf Outdated
Co-authored-by: Roman Tkachenko <roman@goteleport.com>
@github-actions github-actions Bot removed the request for review from codingllama August 17, 2022 13:09
@hugoShaka hugoShaka enabled auto-merge (squash) August 17, 2022 13:13
@hugoShaka hugoShaka merged commit 2baa7e7 into master Aug 17, 2022
@hugoShaka hugoShaka deleted the 4218-update-grafana-in-ami branch September 8, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Grafana in AMI / Examples

3 participants