Remove unused isBillingModeProvisioned var in dynamoevents.go
#15555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatched
approved these changes
Aug 16, 2022
|
@zmb3 The sev1 issue in question was caused by an error triggering during migration and creation of the new index as part of a version upgrade. This code doesn't exist in master as of #12577 after a quick bisection. This is unused because the only branch/bit of code that actually depended on this data to make the correct choice was the migration code. This is safe to remove and is expected. I should've removed this code in the PR mentioned above but missed it. We stripped out the migration code because we don't support such version jumps. This code still exists in v10/v9 which means we won't/cannot backport this PR. |
|
Awesome, thanks for confirming Joel! |
zmb3
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isBillingModeProvisionedindynamoevents.Logdoesn't seem to be in use, so this PR removes it.Testing
None.