Added docs for new RPM repos#15268
Conversation
github-actions
Bot
requested review from
ptgott,
r0mant,
sagesyr,
xinding33 and
zmb3
| ``` | ||
| </TabItem> | ||
|
|
||
| <TabItem label="Amazon Linux 2/RHEL Legacy (RPM)"> |
There was a problem hiding this comment.
Are we planning on maintaining this old repo? I almost think we should remove the instructions to avoid confusion (some people just won't read the "(Legacy)" in the header)
There was a problem hiding this comment.
We'll probably be maintaining old repos (both apt and rpm) for foreseeable future. We thought about removing these instructions but don't want to scare people who still depend on them. Maybe adding a more prominent warning/admonition on this tab would be appropriate - saying that these are legacy ones and you should use the other repo but these aren't going anywhere. cc @fheinecke
|
@ptgott Can you take a look at this please? |
ptgott
force-pushed
the
fred/new-yum-docs
branch
from
c2fb01f to
fc857ac
Compare
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
The "supported versions" link 404s for me. Also, it looks like supported OS versions are spread out across a few declarations, so linking to the source might be a bit inconvenient for users.
Maybe we can add a table above or below the relevant code snippets?
If we're pressed for time, please:
- Remove the "Supported versions are listed here" line from the first code snippet
- Let me know and I can create a docs issue to add context and list supported OS versions
Thanks for catching that. I've updated the APT link and added one for YUM. The declarations are spread out into two structs, but they are os package manager specific. Now that there are two separate links directly tied to what package manager/OS a customer is using I think they can be treated independently. @ptgott Do you still want me to add a table? If so, do you want it in the docs or in the code? I had originally linked to the code as it is the source of truth. If we're going to add table based off that information it doesn't matter to me where it goes. |
|
@fheinecke I think this is okay to merge now! |
* Added docs for new RPM repos * Fixed typos * Added/fixed supported version links * Updated docs to use gpg key in new APT repos
* Added docs for new RPM repos * Fixed typos * Added/fixed supported version links * Updated docs to use gpg key in new APT repos
* Added docs for new RPM repos * Fixed typos * Added/fixed supported version links * Updated docs to use gpg key in new APT repos
…onal#15534) Added docs for new RPM repos (gravitational#15268) * Added docs for new RPM repos * Fixed typos * Added/fixed supported version links * Updated docs to use gpg key in new APT repos
4 participants
Update the YUM install commands to point to the new YUM repos as a part of RFD 0058.
Related PR: #14203