improve semaphore retries and tests#14401
Merged
fspmarshall merged 1 commit intomasterfrom Jul 13, 2022
Merged
Conversation
GavinFrazar
approved these changes
Jul 12, 2022
fspmarshall
force-pushed
the
fspmarshall/improve-semaphore-tests
branch
from
239879b to
212d4d5
Compare
nklaassen
approved these changes
Jul 12, 2022
rosstimothy
approved these changes
Jul 13, 2022
fspmarshall
force-pushed
the
fspmarshall/improve-semaphore-tests
branch
from
212d4d5 to
c649366
Compare
fspmarshall
force-pushed
the
fspmarshall/improve-semaphore-tests
branch
from
c649366 to
7eb77a6
Compare
Contributor
|
@fspmarshall See the table below for backport results.
|
This was referenced Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, in combination with #14187 (recently merged) should reduce the flakiness observed in #13570.
The main improvement made here is to change semaphore operations to occur across a broader range of retry times (full jitter versus half jitter). Since the backoff in these retries are purely about spreading out retry attempts (as opposed to waiting for load to drop off or for some bad state to be resolved), there is no benefit to having a minimum threshold for the backoff. It is difficult to replicate the failures seen in CI, but this change noticeably improves performance which should translate to a reduced sensitivity to the resource constrained environment that tests are run in.