Fix SSO AuthRequest backwards compatibility. #13589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
approved these changes
Jun 16, 2022
zmb3
approved these changes
Jun 16, 2022
…or backwards compatibility.
Joerger
force-pushed
the
joerger/fix-sso-backwards-comp
branch
from
1be4234 to
6ff145e
Compare
Joerger
added a commit
that referenced
this pull request
Jun 17, 2022
This was referenced Jun 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CertTTLin newtypes.XAuthRequesttypes fromtypes.Durationtotime.Duration.types.Durationwould marshalCertTTLas a string, but older Teleport services expectCertTTLto be marshaled as an int64 (time.Duration).As mentioned in the issue, saml and oidc were also affected by this issue.
I tested this change with
oidcon:e PR - https://github.com/gravitational/teleport.e/pull/471
Fixes #13575