⬇️ downgrade Rust to 1.58.1 #13544
Merged
⬇️ downgrade Rust to 1.58.1 #13544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Rust increase our minimum GLIBC requirement, which is not acceptable at this time.
espadolini
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Probably related to rust-lang/rust#90846 which landed in 1.59.0; to fix the same issue we're having, rust-analyzer (rust-lang/rust-analyzer#11558) ended up just changing their build pipelines to use ubuntu 18.04 (in rust-lang/rust-analyzer#11593), so we could consider doing that after the v10 release is over.
|
Thanks for that context. I think for v11 we'll just build everything in CentOS rather than maintaining two builboxes. |
r0mant
approved these changes
Jun 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Rust increase our minimum GLIBC requirement,
which is not acceptable at this time.