Conversation
rosstimothy
reviewed
Jun 14, 2022
smallinsky
reviewed
Jun 14, 2022
Contributor
smallinsky
left a comment
There was a problem hiding this comment.
First pass, I have left some suggestions.
alistanis
reviewed
Jun 15, 2022
Collaborator
Author
|
@rosstimothy @smallinsky @alistanis Sorry about the delay folks, just got a chance to address your comments. PTAL. |
rosstimothy
reviewed
Jun 27, 2022
smallinsky
approved these changes
Jul 6, 2022
rosstimothy
approved these changes
Jul 11, 2022
nklaassen
reviewed
Jul 11, 2022
nklaassen
approved these changes
Jul 12, 2022
alistanis
approved these changes
Jul 12, 2022
gabrielcorado
approved these changes
Jul 12, 2022
Contributor
r0mant
added a commit
that referenced
this pull request
Jul 27, 2022
Add support for proxying tcp apps
|
This method can be used to connect Redshift with Redshift jdbc driver (not postgres driver). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for proxying TCP applications in App Access. Closes #10216. Also closes #10952.
Users can define a TCP application same way as they define HTTP apps, for example in the static config or using dynamic registration:
tsh apps lsnow specifies the application protocol:After fetching credentials for a TCP application, a user starts a local proxy:
Then they can connect to the local proxy with the app's client as if they were connecting to the app directly:
Docs and the webapps PR to update UI for the new audit event will come separately.