[v9] backport #12685 (Add de-duplicating resources when sorting/totalCount is requested) #13451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needed (#12685) Fixes total count errors for the web UI: - Adds de-duplicating matches for `FakePaginate` func. - This change does makes `FakePaginate` less efficient b/c it will always run filter for every resource per fetch versus just running it on the initial fetch to get the total count. - Removes inaccurate de-dupping in the web api layer since we do it from the back now - Adds another criteria when de-duplicating `applications` by checking for its `public_addr` as well as its name.
zmb3
approved these changes
Jun 13, 2022
rosstimothy
approved these changes
Jun 14, 2022
espadolini
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #12685 to branch/v9