Mongo clients with serverSelectionTimeoutMS set to 5000
#13408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
added
tsh
greedy52
changed the title
serverSelectionTimeoutMS serverSelectionTimeoutMS set to 5000
smallinsky
reviewed
Jun 23, 2022
| if c.options.printFormat { | ||
| return fmt.Sprintf(`"%s"`, address.String()) | ||
| } | ||
| return address.String() |
There was a problem hiding this comment.
Don't we need to quote the connectionString to mitigate shell parsing errors ?
So instead of invoking mongosh mongodb://localhost:12345/mydb?serverSelectionTimeoutMS=5000 we should alywas call mongosh "mongodb://localhost:12345/mydb?serverSelectionTimeoutMS=5000" even if TLS routing is disabled ?
There was a problem hiding this comment.
quoted URL will fail exec.Cmd.Run as clients sees the quotation as invalid URL.
I tested this with Teleport Connect today and I've added WithPrintFormat for it to make sure postgres and mongo connection urls are quoted. And also added some more comments on WithPrintFormat
after fix:
I've also added @ravicious for review on that part.
smallinsky
approved these changes
Jun 23, 2022
ravicious
approved these changes
Jun 24, 2022
|
Thanks @ravicious for confirming =D |
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13195
Testing:
tsh db connectmongosh: works as expected, can use the env var to test scenariosmongo: connects fine with provided URL but never times out - I think the client is ignoring the parameter.tsh proxy db --tunnelworks as expectedNote:
This is a temporary solution that tries to resolve most situations. Further investigation will be conducted to find why
tsh db connecttakes very long.Another temporary workaround that can be done by the user is to downgrade to old
mongoclient instead of usingmongosh