-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access request compatibility for servers without v2 api #13373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once @codingllama's comments are addressed
@codingllama Please take another look now |
Hey @xacrimon, the main ask here was if we could add a test for this. WDYT? |
@codingllama Ah, the emails I got from GitHub had that first comment collapsed. If what you're asking is if we can precisely test the compat to make sure it hits the fallback. I'm not sure on how to do that to be honest, you'd have to somehow mock gRPC into thinking a method is unimplemented (otherwise we'd end up with a lot of wacky interfaces and indirections everywhere), I'm not aware of any other similar tests in Teleport but if you have any ideas I'm all ears. |
Approving, as it seems unfair to hold you on something we don't seem to do. We can do a follow up if you like.
I think creating a new gprc.Server and binding proto.UnimplementedAuthServiceServer to it would do it. |
Fixes a compatability issue introduced by security fixes where the client would call a grpc method that doesn't exist.