SQLServer add suport for SSMS client #13337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
database-access
r0mant
approved these changes
Jun 9, 2022
greedy52
approved these changes
Jun 9, 2022
| @@ -76,6 +76,7 @@ func (c *connector) Connect(ctx context.Context, sessionCtx *common.Session, log | |||
| LoginOptions: options, | |||
| Encryption: msdsn.EncryptionRequired, | |||
| TLSConfig: tlsConfig, | |||
| PacketSize: loginPacket.PacketSize(), | |||
There was a problem hiding this comment.
wow. how did you figure this out
There was a problem hiding this comment.
Wireshark has TDS packet filter that allows to visualise SQLServer traffic. Since the tsh proxy db has --tunnel is pretty easy to look/debug db wire protocol.
jakule
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Try to fix SQLServer connection from Windows Management Studio.
The SSMS server client tires to establish severals sequential connections to upstream SQLServer and seems the this affect GUI interaction and connection has some delay:
sqlserver_ux.mov