gRPC conversions - SSO Auth Connectors#13073
Merged
Merged
Conversation
dba3cb6 to
eee64e6
Compare
Tener
approved these changes
Jun 3, 2022
Contributor
|
Thank you for this @Joerger, this set of changes is even larger than I expected it to be. It looks good though. Some unit tests are failing, but this is easily fixable stuff: |
e4f6f8f to
3585a6e
Compare
6f86540 to
a2c6180
Compare
strideynet
approved these changes
Jun 6, 2022
Contributor
strideynet
left a comment
There was a problem hiding this comment.
Looks good just one concern.
r0mant
approved these changes
Jun 6, 2022
d9c58ee to
91da847
Compare
Contributor
|
I think this breaks backward compatibility. I'm unable to login via GitHub when running v10 auth and v9.3.6 proxy. 2022-06-16T10:30:47-04:00 ERRO [WEB] Error creating auth request. auth:github error:[
ERROR REPORT:
Original Error: *trace.BadParameterError request: json: cannot unmarshal number into Go value of type string
Stack Trace:
Caught:
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/httplib/httplib.go:155 github.com/gravitational/teleport/lib/httplib.ConvertResponse
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/auth/clt.go:278 github.com/gravitational/teleport/lib/auth.(*Client).PostJSON
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/auth/clt.go:1244 github.com/gravitational/teleport/lib/auth.(*Client).CreateGithubAuthRequest
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/web/apiserver.go:1063 github.com/gravitational/teleport/lib/web.(*Handler).githubLoginWeb
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/web/apiserver.go:2551 github.com/gravitational/teleport/lib/web.(*Handler).WithRedirect.func1
/tmp/build-darwin-amd64/go/pkg/mod/github.com/gravitational/httprouter@v1.3.1-0.20220408074523-c876c5e705a5/router.go:399 github.com/julienschmidt/httprouter.(*Router).ServeHTTP
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/net/http/server.go:2090 net/http.StripPrefix.func1
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/net/http/server.go:2047 net/http.HandlerFunc.ServeHTTP
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/web/apiserver.go:454 github.com/gravitational/teleport/lib/web.NewHandler.func1
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/net/http/server.go:2047 net/http.HandlerFunc.ServeHTTP
/tmp/build-darwin-amd64/go/pkg/mod/github.com/gravitational/httprouter@v1.3.1-0.20220408074523-c876c5e705a5/router.go:460 github.com/julienschmidt/httprouter.(*Router).ServeHTTP
/private/tmp/build-darwin-amd64/go/src/github.com/gravitational/teleport/lib/web/apiserver.go:215 github.com/gravitational/teleport/lib/web.(*APIHandler).ServeHTTP
/tmp/build-darwin-amd64/go/pkg/mod/github.com/gravitational/oxy@v0.0.0-20211213172937-a1ba0900a4c9/ratelimit/tokenlimiter.go:118 github.com/gravitational/oxy/ratelimit.(*TokenLimiter).ServeHTTP
/tmp/build-darwin-amd64/go/pkg/mod/github.com/gravitational/oxy@v0.0.0-20211213172937-a1ba0900a4c9/connlimit/connlimit.go:75 github.com/gravitational/oxy/connlimit.(*ConnLimiter).ServeHTTP
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/net/http/server.go:2879 net/http.serverHandler.ServeHTTP
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/net/http/server.go:3480 net/http.initALPNRequest.ServeHTTP
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/net/http/h2_bundle.go:5849 net/http.(*http2serverConn).runHandler
/var/folders/ys/8czjjsys38x504kj8172pd_m0000gp/T/drone-MH8sayoNWmwkJaEN/home/drone/build-12784-1655249166-toolchains/go/src/runtime/asm_amd64.s:1581 runtime.goexit
User Message: request: json: cannot unmarshal number into Go value of type string
] web/apiserver.go:1071This looks to be caused by casting the CertTTL to a teleport/api/types/types.proto Lines 2714 to 2715 in 78c1450 The custom marshalling/unmarshalling is expecting to be working with a string which is no longer the case teleport/api/types/duration.go Lines 48 to 66 in 78c1450 |
Joerger
added a commit
that referenced
this pull request
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the following http endpoints to gRPC:
Since the last 4 endpoints are brand new and are being released in v10, they do not need http fallback logic.
See #12783 (comment) for motivation behind this PR.
e PR - https://github.com/gravitational/teleport.e/pull/458
Updates #6394