Refactor rdpdr client#12750

Merged

ibeckermayer merged 151 commits into

windows-desktop-directory-sharingfrom

isaiah/irp-mj-refactor

Jun 25, 2022

Commits on Mar 31, 2022

Creates a general vchan Client that can read chunked messages. rdpdr and cliprdr::Client's have the vchan::Client as a field.
Isaiah Becker-Mayer
committed
Tidying up
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/reuse-vchan-read
Isaiah Becker-Mayer
authored
small fixes
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/reuse-vchan-read
Isaiah Becker-Mayer
authored

Commits on Apr 1, 2022

fixes linting errors
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/reuse-vchan-read
Isaiah Becker-Mayer
authored
Merge branch 'master' into isaiah/reuse-vchan-read
Isaiah Becker-Mayer
authored
Merge branch 'master' into isaiah/reuse-vchan-read
Isaiah Becker-Mayer
authored
Adds drive redirection capability set to the Client Core Capability Response
Isaiah Becker-Mayer
committed

Commits on Apr 4, 2022

Adds the ClientDeviceListAnnounce message, plus some prototype code to trigger it by right-clicking, however it isn't working. One reason is that the vchannel PDU header isn't being added (see rdpd…
Isaiah Becker-Mayer
committed
Adds to_unicode util
Isaiah Becker-Mayer
committed
refactor of vchan and rdpdr to use it
Isaiah Becker-Mayer
committed
refactors cliprdr to use generalized vchan header and chunking
Isaiah Becker-Mayer
committed
nits
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/reuse-vchan-write
Isaiah Becker-Mayer
authored
small fixes from CR
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/reuse-vchan-write
Isaiah Becker-Mayer
authored
Merge branch 'isaiah/reuse-vchan-write' into isaiah/mock-drive-redirection
Isaiah Becker-Mayer
committed

Commits on Apr 6, 2022

A right click sends an ClientDeviceListAnnounce message and the rdp client parses the DeviceCreateRequest that's immediately sent back
Isaiah Becker-Mayer
committed

Commits on Apr 8, 2022

adds prototype logic for handling IRP_MJ_QUERY_INFORMATION and IRP_MJ_CLOSE
Isaiah Becker-Mayer
committed

Commits on Apr 11, 2022

removes some un needed comments. the link to the documentation is enough in most cases, no need to neurotically add every bit of the documentation text to the code itself
Isaiah Becker-Mayer
committed

Commits on Apr 15, 2022

Successfully mocks a drive for redirection
Isaiah Becker-Mayer
committed

Commits on Apr 19, 2022

adding important todo
Isaiah Becker-Mayer
committed

Commits on Apr 25, 2022

removes unneeded pub decl
Isaiah Becker-Mayer
committed
refactors rdpdr into its own self-contained folder module
Isaiah Becker-Mayer
committed

Commits on Apr 26, 2022

moving scard into rdpdr
Isaiah Becker-Mayer
committed
allowing dead code
Isaiah Becker-Mayer
committed
stubs out request_file_info
Isaiah Becker-Mayer
committed

Commits on Apr 27, 2022

fixes mismatched declaration
Isaiah Becker-Mayer
committed
completes IRP_MJ_DEVICE_CONTROL
Isaiah Becker-Mayer
committed
adds a check for allow_directory_sharing so that we guarantee its functionality is disabled if that gets set in RBAC
Isaiah Becker-Mayer
committed
adds SharedDirectoryAnnounce and removes the right click hack from client.go
Isaiah Becker-Mayer
committed

Commits on Apr 28, 2022

Adds SharedDirectoryAcknowledge tdp message, refactors rust-go interface to use the device id created by the client for the SharedDirectoryAnnounce to be used by rdp, rather than hardcoded DRIVE_DE…
Isaiah Becker-Mayer
committed
updates naming convention
Isaiah Becker-Mayer
committed
Making sense of handle_client_id_confirm
Isaiah Becker-Mayer
committed
finishes out shared directory ack
Isaiah Becker-Mayer
committed

Commits on Apr 29, 2022

updates to new sd_acknowledge
Isaiah Becker-Mayer
committed

Commits on Apr 30, 2022

uses a struct for ack
Isaiah Becker-Mayer
committed

Commits on May 2, 2022

roadblock at 'static lifetime error
Isaiah Becker-Mayer
committed

Commits on May 3, 2022

refactors codebase to only contain shared directory announce and shared directory acknowledge
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed

Commits on May 4, 2022

fixes function name typo
Isaiah Becker-Mayer
committed

Commits on May 6, 2022

checking in to go work on other stuff
Isaiah Becker-Mayer
committed
rather than passing errors via C-strings, we pass them as integers which removes a major potential memory leak/error footgun
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/cgo-err-code
Isaiah Becker-Mayer
authored

Commits on May 7, 2022

giving CGOErrCode explicit values
Isaiah Becker-Mayer
committed
removing useless format
Isaiah Becker-Mayer
committed

Commits on May 9, 2022

adding feature flag
Isaiah Becker-Mayer
committed
adding #[allow(dead_code)]
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/cgo-err-code
Isaiah Becker-Mayer
authored
Merge branch 'isaiah/cgo-err-code' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
Debugf
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/cgo-err-code
Isaiah Becker-Mayer
authored
Merge branch 'isaiah/cgo-err-code' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/stub-irp-mj-create
Isaiah Becker-Mayer
committed
removing mentions of code side
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/cgo-err-code' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/stub-irp-mj-create
Isaiah Becker-Mayer
committed
removing dangling CGO_OK
Isaiah Becker-Mayer
committed
making a mod.rs
Isaiah Becker-Mayer
committed
moving scard in rdpdr
Isaiah Becker-Mayer
committed
moves constants into consts.rs
Isaiah Becker-Mayer
committed
Adds go build flags for directory sharing and some basic scaffolding for handling them
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/shared-directory-build-flag' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
reverting e
Isaiah Becker-Mayer
committed

Commits on May 10, 2022

Id to ID
Isaiah Becker-Mayer
committed
typo
Isaiah Becker-Mayer
committed

Commits on May 11, 2022

proof of concept for calling the closures from golang. Checkpoing commit with tdp_sd_create_request, going to delete this on another branch
Isaiah Becker-Mayer
committed
trims rust back to bare minimum required for poc
Isaiah Becker-Mayer
committed
adds TypeSharedDirectoryAcknowledge, TypeSharedDirectoryInfoRequest, and TypeSharedDirectoryInfoResponse
Isaiah Becker-Mayer
committed

Commits on May 12, 2022

Adds sharedDirectoryInfoRequest to go client
Isaiah Becker-Mayer
committed
adds SharedDirectoryInfoResponse to go client
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/rdp-tdp-transl-arch
Isaiah Becker-Mayer
committed
CR
Isaiah Becker-Mayer
committed
fixes compiler errors
Isaiah Becker-Mayer
committed

Commits on May 14, 2022

Adds the straightforward failure modes
Isaiah Becker-Mayer
committed
adds file_cache
Isaiah Becker-Mayer
committed
adds Shared Directory Create Request
Isaiah Becker-Mayer
committed

Commits on May 15, 2022

adds Shared Directory Delete Request
Isaiah Becker-Mayer
committed
fills out the rest of IRP_MJ_CREATE
Isaiah Becker-Mayer
committed
adds plumbing for calling handle_tdp_sd_create_response and handle_tdp_sd_delete_response from go
Isaiah Becker-Mayer
committed
adds logic for calling handle_tdp_sd_create_response and handle_tdp_sd_delete_response from go
Isaiah Becker-Mayer
committed
reverting mistaken Makefile change
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create
Isaiah Becker-Mayer
committed

Commits on May 17, 2022

adds missing STATUS_SUCCESS messages
Isaiah Becker-Mayer
committed
adds logic for IRP_MJ_QUERY_INFORMATION
Isaiah Becker-Mayer
committed
adding dead_code tag
Isaiah Becker-Mayer
committed
reverting Makefile
Isaiah Becker-Mayer
committed
Adds handling of IRP_MJ_CLOSE
Isaiah Becker-Mayer
committed

Commits on May 18, 2022

Merge branch 'master' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
authored
refactored all available, now realizing that I should've branched off of isaiah/irp-mj-close. checking in here to merge that on the next commit, and then do the same refactor patter for irp-mj-close.
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor
Isaiah Becker-Mayer
committed
moves IRP_MJ_CLOSE handling into process_irp_close
Isaiah Becker-Mayer
committed

Commits on May 19, 2022

fixing build bug and go lint errors
Isaiah Becker-Mayer
committed
merging branch isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create
Isaiah Becker-Mayer
committed
reverting Makefile
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-query-information' into isaiah/irp-mj-close
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor
Isaiah Becker-Mayer
committed
Adds CGOTdpErrCode. Go behaves oddly with enums being placed in structs, opting make them go type uint32. We're essentially just handling this manually with errCodeToTdpErrCode.
Isaiah Becker-Mayer
committed
I decided there's no need to use errCodeToTdpErrCode at all. We can just use the normal enum types in typescript and Rust, and trust that the values are correct in Go
Isaiah Becker-Mayer
committed
adding CGOFileType
Isaiah Becker-Mayer
committed
changed up the naming convention for these enums, since the primary reason for the previous convention with CGOErrCode is that we were using members directly in Go. But in this case, we don't touch…
Isaiah Becker-Mayer
committed
fixing rust linting problems
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/rdp-tdp-transl-arch
Isaiah Becker-Mayer
committed
fixing clippy errors
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create
Isaiah Becker-Mayer
committed
Fixes linting errors
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information
Isaiah Becker-Mayer
committed
fixing lint errors and reverting Makefile
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-query-information' into isaiah/irp-mj-close
Isaiah Becker-Mayer
committed
fixing clippy errors
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor
Isaiah Becker-Mayer
committed
fixing clippy errors
Isaiah Becker-Mayer
committed

Commits on May 20, 2022

fixing Makefile
Isaiah Becker-Mayer
committed

Commits on May 23, 2022

reverting mistaken e/webassets update
Isaiah Becker-Mayer
committed
reverting mistaken Makefile change
Isaiah Becker-Mayer
committed

Commits on May 25, 2022

Merge branch 'master' into isaiah/tdp-sd-announce-ack
Isaiah Becker-Mayer
committed

Commits on May 27, 2022

Update lib/srv/desktop/rdp/rdpclient/librdprs.h

Isaiah Becker-Mayer
and
zmb3
authored
Update lib/srv/desktop/rdp/rdpclient/src/lib.rs

Isaiah Becker-Mayer
and
zmb3
authored
Code review
Isaiah Becker-Mayer
committed

Commits on May 31, 2022

refactoring handle_device_reply to clarify which part is for directory sharing vs which part is for smart card redirection
Isaiah Becker-Mayer
committed
changing try_from to as
Isaiah Becker-Mayer
committed
adds doc comment for new_drive
Isaiah Becker-Mayer
committed
adding doc for write_client_device_list_announce
Isaiah Becker-Mayer
committed
Removes CapabilityType::CAP_DRIVE_TYPE from the capability set if directory sharing is disabled (by RBAC)
Isaiah Becker-Mayer
committed
adds docstring to sharedDirectoryAcknowledge
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/rdp-tdp-transl-arch
Isaiah Becker-Mayer
committed

Commits on Jun 13, 2022

Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create
Isaiah Becker-Mayer
committed
removes an unnecessary comment and adds a necessary one
Isaiah Becker-Mayer
committed

Commits on Jun 14, 2022

Adds docstrings to TDP types
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information
Isaiah Becker-Mayer
committed
code readability improvement
Isaiah Becker-Mayer
committed
adding tests for to_windows_time
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/rdp-tdp-transl-arch
Isaiah Becker-Mayer
committed

Commits on Jun 15, 2022

linting
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/rdp-tdp-transl-arch
Isaiah Becker-Mayer
committed
Merge branch 'master' into isaiah/rdp-tdp-transl-arch
Isaiah Becker-Mayer
authored
Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-query-information' into isaiah/irp-mj-close
Isaiah Becker-Mayer
committed
improving code flow
Isaiah Becker-Mayer
committed
adds more clarifying comments
Isaiah Becker-Mayer
committed
Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor
Isaiah Becker-Mayer
committed
style fixes and superfluous code removed
Isaiah Becker-Mayer
committed
changes if-else to match
Isaiah Becker-Mayer
committed

Commits on Jun 25, 2022

Merge branch 'windows-desktop-directory-sharing' into isaiah/irp-mj-refactor
Isaiah Becker-Mayer
committed